Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: cleanup and introduce node wrapper for testing #3661

Closed
mimowo opened this issue Nov 27, 2024 · 6 comments · Fixed by #3689 or #3701
Closed

TAS: cleanup and introduce node wrapper for testing #3661

mimowo opened this issue Nov 27, 2024 · 6 comments · Fixed by #3689 or #3701
Assignees
@kaisoz
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2024

What would you like to be cleaned:

Introduce NodeWrapper for testing, similarly as we have a wrapper for creating pods.

Why is this needed:

Currently creating nodes for testing is quite verbose, example.
For comparison, pods can be created much more compactly, example
@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 27, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 27, 2024

cc @mbobrovskyi @tenzen-y @kaisoz

@kaisoz
Copy link
Contributor

kaisoz commented Nov 27, 2024

/assign

I can take care of this one if this is ok for you 😊

@mimowo
Copy link
Contributor Author

mimowo commented Nov 27, 2024

sure, thanks!

@tenzen-y
Copy link
Member

/assign

I can take care of this one if this is ok for you 😊

Awsome contribution!

@kaisoz kaisoz mentioned this issue Nov 29, 2024
Merged
@mimowo
Copy link
Contributor Author

mimowo commented Dec 2, 2024

/reopen
To refactor remaining tests

@k8s-ci-robot k8s-ci-robot reopened this Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

@mimowo: Reopened this issue.

In response to this:

/reopen
To refactor remaining tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaisoz kaisoz mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaisoz kaisoz

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NodeWrapper for testing kaisoz/kueue
Use NodeWrapper in test files kaisoz/kueue
4 participants
@kaisoz @mimowo @k8s-ci-robot @tenzen-y