Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hierarchical Cohorts] Preemption only fetches candidates of ClusterQueue's parent Cohort #3583

Open
gabesaba opened this issue Nov 18, 2024 · 1 comment · May be fixed by #3691
Open

[Hierarchical Cohorts] Preemption only fetches candidates of ClusterQueue's parent Cohort #3583

gabesaba opened this issue Nov 18, 2024 · 1 comment · May be fixed by #3691
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gabesaba
Copy link
Contributor

What happened:
We need to traverse entire Cohort tree for preemption candidates, not just the ClusterQueues in the preempting ClusterQueue's parent Cohort

kueue/pkg/scheduler/preemption/preemption.go

Line 516 in 94d8292

for _, cohortCQ := range cq.Parent().ChildCQs() {

@gabesaba gabesaba added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2024
@gabesaba
Copy link
Contributor Author

cc @mimowo

@gabesaba gabesaba linked a pull request Nov 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix preemption.findCandidates for Hierarchical Cohorts gabesaba/kueue
1 participant
@gabesaba