Add wrapper for ProvisioningRequestConfig to util/testing package

[TusharMohapatra07]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve code quality

Which issue(s) this PR fixes:

Fixes #3472

NONE

[k8s-ci-robot]

Hi @TusharMohapatra07. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	b597749
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6749668c0f36e800084e2e74

[TusharMohapatra07]

@PBundyra @mimowo What other operations(methods) are expected on the wrapper??

[mbobrovskyi]

What is the purpose of this wrapper if it is never used?

[TusharMohapatra07]

@mbobrovskyi The issue says to create a wrapper for ProvisioningRequestConfig.

[mbobrovskyi]

@mbobrovskyi The issue says to create a wrapper for ProvisioningRequestConfig.

I agree the issue description is unclear. However, we need to not only create the wrapper but also use it in the code.

[PBundyra]

@PBundyra @mimowo What other operations(methods) are expected on the wrapper??

We need methods to set:

• .spec.provisioningClassName
• .spec.parameters
• .spec.managedResources
• .spec.retryStrategy
• .spec.retryStrategy.backoffLimitCount
• .spec.retryStrategy.backoffBaseSeconds
• .spec.retryStrategy.backoffMaxSeconds

And to create an actual object from a wrapper.

The point of introducing the wrapper would be indeed to use as @mbobrovskyi mentioned. Sorry for the unclear description. This change should be reflected in files:

• pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler_test.go
• pkg/controller/admissionchecks/provisioning/controller_test.go
• pkg/util/admissioncheck/admissioncheck_test.go
• test/integration/controller/admissionchecks/provisioning/provisioning_test.go

[TusharMohapatra07]

@mbobrovskyi @PBundyra Sorry for being late. I've used the wrapper in controller_test.go. I shall proceed with further using the wrapper post approval.

[mbobrovskyi]

/ok-to-test

[mbobrovskyi]

@TusharMohapatra07 please apply for other files.

[PBundyra]

Please add methods for fields:

.spec.managedResources
.spec.retryStrategy.backoffLimitCount
.spec.retryStrategy.backoffBaseSeconds
.spec.retryStrategy.backoffMaxSeconds

[TusharMohapatra07]

@mbobrovskyi @PBundyra Is this what's intended ?

[mbobrovskyi]

It should work.

[]kueue.ProvisioningRequestConfig{*baseConfigWithRetryStrategy.Clone().RetryLimit(1).BaseBackoff(0).Obj()},

Yaa that's what, i need to dereference it

The question not about references. But use DeepCopy() only if it's really need.

[TusharMohapatra07]

@mbobrovskyi just to confirm, i don't have to use Obj() here right ?

[PBundyra]

@mbobrovskyi just to confirm, i don't have to use Obj() here right ?

You should Clone() the base wrapper and then use Obj() to create the actual underlying object from the wrapper

[TusharMohapatra07]

I've used the wrapper in admissioncheck_reconciler_test.go, admissioncheck_test.go(there was nothing much to do in these two) and provisioning_test.go. Please review @mbobrovskyi

[mbobrovskyi]

/test all

[mbobrovskyi]

LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi, TusharMohapatra07
Once this PR has been reviewed and has the lgtm label, please assign kerthcet, trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS
• pkg/util/OWNERS
• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mbobrovskyi]

/lgtm
Awesome! Thank you so much!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 278ad740d7663cea89a8e17b0082eb6757fe3e2e

[mbobrovskyi]

Please also open the PR.

[TusharMohapatra07]

@mbobrovskyi done

[mbobrovskyi]

/cc @mimowo

[PBundyra]

LGTM from me as well, good job @TusharMohapatra07