Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky - Creating a multikueue admission check Should run a job on worker if admitted #3685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IrvingMg
Copy link
Contributor

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Adds a check when syncing jobs on multikueue to avoid trying to patch the spec before resuming the job.

Which issue(s) this PR fixes:

Fixes #3600

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. labels Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IrvingMg
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 9007081
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6748a8e320f2a8000815f1e4
😎 Deploy Preview https://deploy-preview-3685--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IrvingMg IrvingMg changed the title Fix flaky e2e test - Creating a multikueue admission check Should run a job on worker if admitted Fix flaky - Creating a multikueue admission check Should run a job on worker if admitted Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

@IrvingMg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main 9007081 link true /test pull-kueue-test-unit-main
pull-kueue-test-integration-main 9007081 link true /test pull-kueue-test-integration-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multiKueue flakes] Creating a multikueue admission check Should run a job on worker if admitted
2 participants