Container Stop Signals

[sreeram-venkitesh]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add support to configure custom stop signals for containers
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4960-container-stop-signals/README.md
• Discussion Link: Add support for custom stop signal to send to containers kubernetes#30051
• Primary contact (assignee): @sreeram-venkitesh
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.33
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP 4960: Container Stop Signals #5122
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sreeram-venkitesh]

/sig node

[sreeram-venkitesh]

Related: kubernetes/kubernetes#128030. Will work on the KEP before v1.33.

[haircommander]

/label lead-opted-in
/milestone v1.33

[bianbbc87]

Hello @sreeram-venkitesh 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.33. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria.
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sreeram-venkitesh]

Thanks @bianbbc87! I have #5122 open which is under review. I will update these in the same PR.

[bianbbc87]

@sreeram-venkitesh
Hi ! Please write the same PR to Alpha KEP later as well.

Thank you !

[dipesh-rawat]

Hi @sreeram-venkitesh 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4960 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

@dipesh-rawat Thanks for the ping! The discussion around PRR is still going on in #5122, I'm hoping to get it merged before the freeze. #5122 should address all our requirements.

[sreeram-venkitesh]

@bianbbc87 @dipesh-rawat #5122 has been merged! PTAL!

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, 1.33 Enhancements team here,

With PR #5122 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nit could be addressed:

• Update issue description to add direct link to KEP README.md.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4960-container-stop-signals/README.md

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @bianbbc87)

/label tracked/yes

[sreeram-venkitesh]

Update issue #4960 (comment) to add direct link to KEP README.md.

Done.

[Urvashi0109]

Hello @sreeram-venkitesh 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!