Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use imagePullPolicy: Always on prow jobs #33868

Open
aojea opened this issue Nov 28, 2024 · 5 comments
Open

Don't use imagePullPolicy: Always on prow jobs #33868

aojea opened this issue Nov 28, 2024 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@aojea
Copy link
Member

aojea commented Nov 28, 2024

          Which was from me then. But I, too, must have copied it from somewhere else.

Probably pull-kubernetes-verify:

- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241127-f74b74d1f9-master
imagePullPolicy: Always

There's a ton of other hits when grepping for it:
https://github.com/search?q=repo%3Akubernetes%2Ftest-infra%20%22imagePullPolicy%3A%20Always%22&type=code

Originally posted by @pohly in #33866 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 28, 2024
@pohly
Copy link
Contributor

pohly commented Nov 28, 2024

Why we want this: imagePullPolicy: Always causes additional overhead when the image has a fixed version and doesn't get updated in the registry. Use it only if the image is a floating reference.

@BenTheElder
Copy link
Member

We intentionally used it on some jobs that trial the absolutely latest image, but most jobs shouldn't be using it.

@BenTheElder
Copy link
Member

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 3, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2025
@pohly
Copy link
Contributor

pohly commented Mar 4, 2025

/remove lifecycle-stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants