Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commands telemetry to be filter by command trigger #63

Open
f1ames opened this issue Dec 4, 2023 · 1 comment
Open

Allow commands telemetry to be filter by command trigger #63

f1ames opened this issue Dec 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@f1ames
Copy link
Contributor

f1ames commented Dec 4, 2023

Most of the commands are triggered only by users but some are also called automatically from code (validate and watch). This makes those two really stand out in metrics and also we don't have a way to distinguish if it was an user explicitly using such command or if it was a part of execution flow.

My idea is to add a flag/param to command telemetry data so we can distinguish and group commands (or filter out) based on the trigger.

@olensmar would it help, WDYT?

@f1ames f1ames added the enhancement New feature or request label Dec 4, 2023
@olensmar
Copy link
Member

olensmar commented Dec 4, 2023

definitely would help - sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants