-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request #23
Comments
I think this might be possible but each of the GX device platforms will have different parameters. By inspection, Cerbo has .../adc_builtin0/1/... .../adc_builtin0/4/... for tanks. I'm not sure what other platforms would have. I would need a complete list of dbus Settings parameters to include them all. Analog hats on the Raspberry PI would probably also have dbus parameters different from other platforms and may in fact change based on the analog interface. Then there are separate setting parameters for the GX Tank. I would not be able to include these in the backup and restore because the dbus path includes the GX Tank's serial number which is not consistent between systems. Unfortunately other external tank sensors utilize the external device's name (or other field) instead of having something in dbus Settings. So these would also not be included. So if I did this, it would support ONLY Cerbo built-in tanks. |
I understand about the different platforms. In my case, I consistently deploy on a CerboGX with analog tank 1 which includes a custom name and Ohm settings for trailers that all use a 30gal tank for a diesel generator. I’m hoping not to have to manually input the tank info on every unit I deploy.
From: kwindrem ***@***.***>
Sent: Wednesday, August 31, 2022 5:18 PM
To: kwindrem/SetupHelper ***@***.***>
Cc: Tim Lewis ***@***.***>; Author ***@***.***>
Subject: Re: [kwindrem/SetupHelper] Feature Request (Issue #23)
I think this might be possible but each of the GX device platforms will have different parameters. By inspection, Cerbo has .../adc_builtin0/1/... .../adc_builtin0/4/... for tanks. I'm not sure what other platforms would have. I would need a complete list of dbus Settings parameters to include them all. Analog hats on the Raspberry PI would probably also have dbus parameters different from other platforms and may in fact change based on the analog interface.
Then there are separate setting parameters for the GX Tank. I would not be able to include these in the backup and restore because the dbus path includes the GX Tank's serial number which is not consistent between systems.
Unfortunately other external tank sensors utilize the external device's name (or other field) instead of having something in dbus Settings. So these would also not be included.
So if I did this, it would support ONLY Cerbo built-in tanks.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPJW7YUUD2QXEGNIYSTV37DXBANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
I have added Cerbo tanks (and temps) -- including alarms to backup and restore. It's currently on the beta branch so change the SetupHelper branch in PackageManager to get that version for testing. You can also download from GitHub and install manually if you prefer. Make sure you select the beta branch before downloading! I'll release as soon as you report back and I've fixed any bugs. |
Fantastic, I’ll test tomorrow.
…Sent from my iPhone
On Aug 31, 2022, at 6:39 PM, kwindrem ***@***.***> wrote:
I have added Cerbo tanks (and temps) -- including alarms to backup and restore. It's currently on the beta branch so change the SetupHelper branch in PackageManager to get that version for testing.
You can also download from GitHub and install manually if you prefer. Make sure you select the beta branch before downloading!
I'll release as soon as you report back and I've fixed any bugs.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPICI2DAECHFYGOMDOTV37NIZANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I have tested with the following:
V2.90~26 Einstein firmware
V4.23~1 SetupHelper
When you first go into Settings/ I/O /Analog inputs Tanks Level input 1 is off
[A screenshot of a computer Description automatically generated with medium confidence]
Randomly I toggled tank 4 and tank 1 also came on making me thing the GUI just didn’t refresh properly
[A screenshot of a computer Description automatically generated with medium confidence]
Looking at the devices page it looks like the customizations are restored
[Graphical user interface, application Description automatically generated]
When I drill down into Geni Diesel 30gal setup, I realize not all setting are restored. It sets the Standard to custom but for the values it uses the European default values of 0 and 180. You can see from the attached settingBackup this should be 250 and 35
[A screenshot of a computer Description automatically generated with medium confidence]
FYI, please let me know if you need a CerboGX for testing. You can email me outside of github with shipping info and I would send you one you can keep.
Tim
From: kwindrem ***@***.***>
Sent: Wednesday, August 31, 2022 6:39 PM
To: kwindrem/SetupHelper ***@***.***>
Cc: Tim Lewis ***@***.***>; Author ***@***.***>
Subject: Re: [kwindrem/SetupHelper] Feature Request (Issue #23)
I have added Cerbo tanks (and temps) -- including alarms to backup and restore. It's currently on the beta branch so change the SetupHelper branch in PackageManager to get that version for testing.
You can also download from GitHub and install manually if you prefer. Make sure you select the beta branch before downloading!
I'll release as soon as you report back and I've fixed any bugs.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPICI2DAECHFYGOMDOTV37NIZANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
So disregard the previous email. I setup another test and this time I rebooted after completing the restore and everything is perfect. |
I did some tests with dbus-spy and unless the standard is set to custom, changes to the sensor empty/full values are rejected. In fact, setting to US or European sets the empty/full values to defaults for those standards !!! I looked at my settingsList and the standard is set AFTER the values. I reordered things and ran a test and the custom empty/full values seem to be restored properly. v4.23~2 is up on GitHub now. Give it a shot. |
The custom Ohm settings work now without a reboot. Prior to reboot, if you look in settings\i\o\analog tanks, tank 1 is still off. It must be on because the tank shows up on the Device screen. After a reboot, tank 1 does show on under analog tanks, all without any user intervention.
From: kwindrem ***@***.***>
Sent: Thursday, September 1, 2022 1:01 PM
To: kwindrem/SetupHelper ***@***.***>
Cc: Tim Lewis ***@***.***>; Author ***@***.***>
Subject: Re: [kwindrem/SetupHelper] Feature Request (Issue #23)
I did some tests with dbus-spy and unless the standard is set to custom, changes to the sensor empty/full values are rejected. In fact, setting to US or European sets the empty/full values to defaults for those standards !!!
I looked at my settingsList and the standard is set AFTER the values. I reordered things and ran a test and the custom empty/full values seem to be restored properly.
v4.23~2 is up on GitHub now. Give it a shot.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPKTCBA3D2YRF5JRSHLV4DON7ANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
I tried this on my Cerbo and the tank shows in the GuiMods enhanced overviews without a reboot. And as you say, it is showing up in the device list. I also discovered what you did -- that the tank input switch shows off in the Analog inputs menu. I changed the Function dbus Setting for that input and the switch setting did not change. I also found I could no longer change the switch in the menu. I restarted the GUI (kill all gui) and the tank then shows as on. It appears that menu is not refreshing when parameters change from something outside that menu. I don't fully what is going on in that menu or how to fix it. |
My two cents, I think it is a very minor nuisance and if I wasn’t actually testing your release I wouldn’t have noticed. I’m also not bothered by having to do a reboot after restoring settings.
…Sent from my iPhone
On Sep 1, 2022, at 5:19 PM, kwindrem ***@***.***> wrote:
I tried this on my Cerbo and the tank shows in the GuiMods enhanced overviews without a reboot. And as you say, it is showing up in the device list. I also discovered what you did -- that the tank input switch shows off in the Analog inputs menu. I changed the Function dbus Setting for that input and the switch setting did not change. I also found I could no longer change the switch in the menu.
I restarted the GUI (kill all gui) and the tank then shows as on.
It appears that menu is not refreshing when parameters change from something outside that menu. I don't fully what is going on in that menu or how to fix it.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPL2GFI7QODLRCOJIMLV4EMW3ANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Agreed on the tank on/off issue. It turns out if you change ANY switch setting in this menu, it refreshes the other switches also. If you have more testing to do, I'll hold off releasing, otherwise, I'm ready on my end. |
I’m good,
Thanks!
…Sent from my iPhone
On Sep 1, 2022, at 6:11 PM, kwindrem ***@***.***> wrote:
Agreed on the tank on/off issue. It turns out if you change ANY switch setting in this menu, it refreshes the other switches also.
If you have more testing to do, I'll hold off releasing, otherwise, I'm ready on my end.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPOJGE5YQCFKJTKOH53V4ESZBANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Kevin,
No rush, just making sure you’re not waiting on me?
Tim
…Sent from my iPhone
On Sep 1, 2022, at 6:11 PM, kwindrem ***@***.***> wrote:
Agreed on the tank on/off issue. It turns out if you change ANY switch setting in this menu, it refreshes the other switches also.
If you have more testing to do, I'll hold off releasing, otherwise, I'm ready on my end.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPOJGE5YQCFKJTKOH53V4ESZBANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No. Just got sidetracked on other things. I’ll release now.
—
Kevin
… On Sep 2 2022, at 3:02 PM, tlewis99 ***@***.***> wrote:
Kevin,
No rush, just making sure you’re not waiting on me?
Tim
Sent from my iPhone
On Sep 1, 2022, at 6:11 PM, kwindrem ***@***.***> wrote:
Agreed on the tank on/off issue. It turns out if you change ANY switch setting in this menu, it refreshes the other switches also.
If you have more testing to do, I'll hold off releasing, otherwise, I'm ready on my end.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARAILPOJGE5YQCFKJTKOH53V4ESZBANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN6TTG7RVJ2ZWA6YF6NAZZDV4J2QRANCNFSM6AAAAAAQBTRZTQ>.
You are receiving this because you commented.
|
An idea for the Mopeka devices, so in my Caravan I have a Mopeka LPG device. It is working fine. I've also got a back order for the Water Tank Monitors (for my fresh water). It would be great to calculate (guesstimate) the lifespan of these tanks as to when they will get to empty... rather than get a cold shower, or simply no water. Resolution to an hour based on the last day or two would be perfect. |
Is is possible to include in the backup and restore settings:
I/O / Analog tanks settings
then any customizations about Analog tanks made from the Device menu?
Let me know your thoughts.
Thanks,
Tim
The text was updated successfully, but these errors were encountered: