Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: Accept newer versions of PyYAML #1153

Closed

Conversation

edersondisouza
Copy link
Contributor

Instead of requiring exactly PyYAML 5.4.1, use that version as the minimum requirement. This will help avoid conflicts with other packages that usually require a newer version of PyYAML.

Description

Requiring an specific version of PyYAML is causing conflicts with other project requirements, that are requiring PyYAML 6.0 (released on October 2021) as minimum. Running the tests, I didn't see any issue, and #1019 also increases the confidence that there are no issues.

Checklist

  • Tests for the feature
  • PR has been tested

Instead of requiring exactly PyYAML 5.4.1, use that version as the
minimum requirement. This will help avoid conflicts with other packages
that usually require a newer version of PyYAML.

Signed-off-by: Ederson de Souza <[email protected]>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e4dea3) 63.2% compared to head (768fe2e) 63.2%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1153   +/-   ##
======================================
  Coverage    63.2%   63.2%           
======================================
  Files         156     156           
  Lines       11571   11571           
======================================
+ Hits         7315    7317    +2     
+ Misses       4256    4254    -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Emantor
Copy link
Member

Emantor commented Apr 27, 2023

See #1136 which unpins all dependencies. This is finally possible since we removed crossbar from the optional installs, which affords us the freedom to have unpinned dependencies again (which is correct for a library)

@Emantor
Copy link
Member

Emantor commented Apr 27, 2023

I just merged unpinned dependencies and tagged a first alpha release which contains the change.
You can test this by using pip install --upgrade --pre labgrid, which will install the latest pre-release version.

@edersondisouza
Copy link
Contributor Author

See #1136 which unpins all dependencies. This is finally possible since we removed crossbar from the optional installs, which affords us the freedom to have unpinned dependencies again (which is correct for a library)

Oh, that's great! Sorry missed that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants