Skip to content

Commit ed2888c

Browse files
committed
Fix server related tests (different error messages) on Windows
1 parent c0c00e6 commit ed2888c

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

echo_test.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"net/http/httptest"
1212
"net/url"
1313
"os"
14+
"runtime"
1415
"strings"
1516
"testing"
1617
"time"
@@ -927,7 +928,11 @@ func TestEcho_Start(t *testing.T) {
927928
case <-time.After(250 * time.Millisecond):
928929
t.Fatal("start did not error out")
929930
case err := <-errChan:
930-
assert.Contains(t, err.Error(), "bind: address already in use")
931+
expectContains := "bind: address already in use"
932+
if runtime.GOOS == "windows" {
933+
expectContains = "bind: Only one usage of each socket address"
934+
}
935+
assert.Contains(t, err.Error(), expectContains)
931936
}
932937
}
933938

server_test.go

+11-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"net"
1616
"net/http"
1717
"os"
18+
"runtime"
1819
"strings"
1920
"testing"
2021
"time"
@@ -119,7 +120,11 @@ func TestStartConfig_Start(t *testing.T) {
119120
t.Errorf("missing error")
120121
return
121122
}
122-
assert.True(t, strings.Contains(err.Error(), "connect: connection refused"))
123+
expectContains := "connect: connection refused"
124+
if runtime.GOOS == "windows" {
125+
expectContains = "No connection could be made"
126+
}
127+
assert.True(t, strings.Contains(err.Error(), expectContains))
123128
}
124129

125130
func TestStartConfig_GracefulShutdown(t *testing.T) {
@@ -207,7 +212,11 @@ func TestStartConfig_GracefulShutdown(t *testing.T) {
207212
code, body, err = doGet(fmt.Sprintf("http://%v/ok", addr))
208213
assert.Error(t, err)
209214
if err != nil {
210-
assert.True(t, strings.Contains(err.Error(), "connect: connection refused"))
215+
expectContains := "connect: connection refused"
216+
if runtime.GOOS == "windows" {
217+
expectContains = "No connection could be made"
218+
}
219+
assert.True(t, strings.Contains(err.Error(), expectContains))
211220
}
212221
assert.Equal(t, 0, code)
213222
assert.Equal(t, "", body)

0 commit comments

Comments
 (0)