Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude examples from pnpm-workspace #940

Closed
anbraten opened this issue Jun 7, 2023 · 2 comments · Fixed by #1029
Closed

Exclude examples from pnpm-workspace #940

anbraten opened this issue Jun 7, 2023 · 2 comments · Fixed by #1029

Comments

@anbraten
Copy link
Contributor

anbraten commented Jun 7, 2023

To speed up pnpm install in CI & docker builds I would suggest to maybe remove examples/* from the pnpm-workspaces.yaml config. This way the examples would also be more self-contained.

@QuiiBz
Copy link
Member

QuiiBz commented Jun 7, 2023

I'm not sure if this is something we want to do, because of

We could run a pnpm install inside each example when running integration tests but that might be slower than just installing them in one go.

What's your opinion on this?

@anbraten
Copy link
Contributor Author

anbraten commented Jun 7, 2023

Maybe a separate pnpm workspace with its own lockfile in the example folder could do the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants