|
| 1 | +Contributing |
| 2 | +============ |
| 3 | + |
| 4 | +We are interested in various different kinds of improvement for scrapd; please feel free to |
| 5 | +raise an `Issue`_ if you would like to work on something major to ensure efficient collaboration and avoid duplicate |
| 6 | +effort. |
| 7 | + |
| 8 | +Guidelines |
| 9 | +---------- |
| 10 | + |
| 11 | +Use the provided templates to file an `Issue`_ or a `Pull Request`_. |
| 12 | + |
| 13 | +Create a topic branch from where you want to base your work. |
| 14 | + |
| 15 | +For formatting the files properly, please use `YAPF`_.In the root directory of the project, run the following command: |
| 16 | + |
| 17 | +.. code-block:: bash |
| 18 | +
|
| 19 | + make format |
| 20 | +
|
| 21 | +Make sure you added tests to validate your changes. |
| 22 | + |
| 23 | +Run all the tests to ensure nothing else was accidentally broken. |
| 24 | + |
| 25 | +Commit messages must start with a capitalized and short summary (max. 50 chars) written in the imperative, followed by |
| 26 | +an optional, more detailed explanatory text which is separated from the summary by an empty line. |
| 27 | + |
| 28 | +Commit messages should follow best practices, including explaining the context of the problem and how it was solved, |
| 29 | +including in caveats or follow up changes required. They should tell the story of the change and provide readers |
| 30 | +understanding of what led to it. Please refer to `How to Write a Git Commit Message`_ for more details. |
| 31 | + |
| 32 | +Formatting your code |
| 33 | +-------------------- |
| 34 | + |
| 35 | +There is also a lot of YAPF plugins available for different editors. Here are a few: |
| 36 | + |
| 37 | + * `atom.io <https://atom.io/packages/python-yapf>`_ |
| 38 | + * `emacs <https://github.com/paetzke/py-yapf.el>`_ |
| 39 | + * `sublime text <https://github.com/jason-kane/PyYapf>`_ |
| 40 | + * `vim <https://github.com/google/yapf/blob/master/plugins/yapf.vim>`_ |
| 41 | + |
| 42 | +.. _`Issue`: https://github.com/rgreinho/scrapd/issues |
| 43 | +.. _`Pull Request`: https://github.com/rgreinho/scrapd/pulls |
| 44 | +.. _`YAPF`: https://github.com/google/yapf |
| 45 | +.. _`How to Write a Git Commit Message`: http://chris.beams.io/posts/git-commit |
0 commit comments