Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facetSRPDynamicEffector module DCM #358

Open
leahkiner opened this issue Nov 22, 2024 · 0 comments · May be fixed by #359
Open

Fix facetSRPDynamicEffector module DCM #358

leahkiner opened this issue Nov 22, 2024 · 0 comments · May be fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@leahkiner
Copy link
Collaborator

Describe the bug
The computed dcm_BB0 DCM in the facetSRPDynamicEffector module that maps the facet normal vectors to the spacecraft body frame needs to be transposed. The rotation of the facet normal vector is an active rotation; however the computed DCM in the module is for a passive rotation. The correct transformation is therefore the transpose of the passive rotation matrix.

This bug was pointed out by @rcalaon when he was not obtaining expected results from the module. Applying the transpose resolved the issue and he sees the expected results.

@leahkiner leahkiner added the bug Something isn't working label Nov 22, 2024
@leahkiner leahkiner self-assigned this Nov 22, 2024
@leahkiner leahkiner moved this to In Progress in Basilisk Nov 22, 2024
@leahkiner leahkiner linked a pull request Nov 22, 2024 that will close this issue
@leahkiner leahkiner linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant