Skip to content

Commit 55d0152

Browse files
committed
fixup better test coverage for create_packet_list
1 parent d33772f commit 55d0152

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

tests/integration/test_xarr.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ def test_create_xarray_dataset_ctim(ctim_test_data_dir, caplog):
4444
"""CTIM data contains many APIDs"""
4545
packet_file = ctim_test_data_dir / "ccsds_2021_155_14_39_51"
4646
definition_file = ctim_test_data_dir / "ctim_xtce_v1.xml"
47-
ds = create_dataset(packet_file, definition_file, root_container_name="CCSDSTelemetryPacket", parse_bad_pkts=False)
48-
print(ds)
47+
_ = create_dataset(packet_file, definition_file, root_container_name="CCSDSTelemetryPacket", parse_bad_pkts=False)
4948

5049

5150
def test_create_xarray_dataset_suda(suda_test_data_dir):
@@ -54,4 +53,4 @@ def test_create_xarray_dataset_suda(suda_test_data_dir):
5453
definition_file = suda_test_data_dir / "suda_combined_science_definition.xml"
5554
# SUDA has a polymorphic packet structure
5655
with pytest.raises(ValueError, match="Packet fields do not match for APID 1425"):
57-
create_dataset(packet_file, definition_file, skip_header_bytes=4)
56+
_ = create_dataset(packet_file, definition_file, skip_header_bytes=4)

tests/unit/test_space_packet_parser.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,17 @@ def test_load_xtce(jpss_test_data_dir, tmp_path):
1717

1818
def test_create_packet_list(jpss_test_data_dir):
1919
"""Test directly creating a list of Packets from a data file and a definition"""
20-
data_files = [
21-
jpss_test_data_dir / "J01_G011_LZ_2021-04-09T00-00-00Z_V01.DAT1",
22-
jpss_test_data_dir / "J01_G011_LZ_2021-04-09T00-00-00Z_V01.DAT1"
23-
]
24-
xtce_file = jpss_test_data_dir / "jpss1_geolocation_xtce_v1.xml"
25-
packet_list = spp.create_packet_list(
26-
data_files,
27-
xtce_file
28-
)
20+
jpss_packets = jpss_test_data_dir / "J01_G011_LZ_2021-04-09T00-00-00Z_V01.DAT1"
21+
jpss_xtce = jpss_test_data_dir / "jpss1_geolocation_xtce_v1.xml"
22+
23+
# Single file
24+
packet_list = spp.create_packet_list(jpss_packets, jpss_xtce)
25+
assert len(packet_list) == 7200
26+
assert packet_list[0]["PKT_APID"] == 11
27+
assert packet_list[-1]["PKT_APID"] == 11
28+
29+
# Multiple files
30+
packet_list = spp.create_packet_list([jpss_packets, jpss_packets], jpss_xtce)
2931
assert len(packet_list) == 14400
3032
assert packet_list[0]["PKT_APID"] == 11
3133
assert packet_list[-1]["PKT_APID"] == 11

0 commit comments

Comments
 (0)