-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure build for span implementation #634
Comments
GCC 10 and clang 11 - the oldest supported compilers - both have The remaining GSL feature used would be |
The issue with my suggestion above is that we can't selectively enable C++20 library features while the library remains C++17 |
@thompsonbry, would there be a problem if the library switched to C++20 to the extent GCC 10 supports it already? |
That would be fine. We are using 10.5.0
…On Mon, Jan 13, 2025 at 7:38 AM Laurynas Biveinis ***@***.***> wrote:
@thompsonbry <https://github.com/thompsonbry>, would there be a problem
if the library switched to C++20 to the extent GCC 10 supports it already?
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATW7YETYWJTEJZIEZMEDZT2KPMVPAVCNFSM6AAAAABVCROVU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXGQ2TONZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Should this issue be closed? |
I think we can close it once we actually have tests for span-based keys |
At some point span is part of c++ and we should adapt the build to that. It leaks through the API since the value_view (and soon the key) will be spans. So it is unfortunate that we do not have a stable type here. A configurable using declaration and include for the build might help with that.
The text was updated successfully, but these errors were encountered: