Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure build for span implementation #634

Open
thompsonbry opened this issue Jan 13, 2025 · 6 comments
Open

Configure build for span implementation #634

thompsonbry opened this issue Jan 13, 2025 · 6 comments
Assignees

Comments

@thompsonbry
Copy link

At some point span is part of c++ and we should adapt the build to that. It leaks through the API since the value_view (and soon the key) will be spans. So it is unfortunate that we do not have a stable type here. A configurable using declaration and include for the build might help with that.

@laurynas-biveinis
Copy link
Owner

GCC 10 and clang 11 - the oldest supported compilers - both have std::span. Do you think there would be any issues in just switching?

The remaining GSL feature used would be narrow_cast, and I'm OK with reimplementing or even dropping it

@laurynas-biveinis
Copy link
Owner

laurynas-biveinis commented Jan 13, 2025

The issue with my suggestion above is that we can't selectively enable C++20 library features while the library remains C++17

@laurynas-biveinis
Copy link
Owner

laurynas-biveinis commented Jan 13, 2025

@thompsonbry, would there be a problem if the library switched to C++20 to the extent GCC 10 supports it already?

@thompsonbry
Copy link
Author

thompsonbry commented Jan 13, 2025 via email

@thompsonbry
Copy link
Author

Should this issue be closed?

@laurynas-biveinis
Copy link
Owner

I think we can close it once we actually have tests for span-based keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants