Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfold Not in conclusions of forward rules? #197

Open
JLimperg opened this issue Feb 26, 2025 · 1 comment
Open

Unfold Not in conclusions of forward rules? #197

JLimperg opened this issue Feb 26, 2025 · 1 comment

Comments

@JLimperg
Copy link
Collaborator

The forward rule

@[aesop safe destruct] theorem not_prime_one : ¬Prime 1

(taken from Mathlib) currently means that in any context, ¬Prime 1 should be added as a hypothesis. But it was perhaps intended to mean that in a context with h : Prime 1, Aesop should derive False.

Possible actions:

  • When adding a forward rule, unfold a leading Not in the conclusion. It should be possible to disable this behaviour via a builder option since adding a forward rule with negative conclusion is not necessarily wrong.
  • Warn when adding a forward rule with a negated conclusion.
@JLimperg
Copy link
Collaborator Author

Also, forward rules with conclusion False and no non-immediate premises should always use destruct since there's no reason to keep the matched hyps around. Or there could be special support that lets forward rules with conclusion False immediately close the goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant