Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"-f" flag not recognized as alternative to "--features" #5682

Closed
3 tasks done
James-Oswald opened this issue Oct 12, 2024 · 1 comment · Fixed by #5685
Closed
3 tasks done

"-f" flag not recognized as alternative to "--features" #5682

James-Oswald opened this issue Oct 12, 2024 · 1 comment · Fixed by #5685
Labels
bug Something isn't working

Comments

@James-Oswald
Copy link
Contributor

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

lean -h states that lean -f may be used as shorthand for lean --features.

  -f, --features         display features compiler provides (eg. LLVM support)

while lean --features works as intended, -f is not recognized as a valid flag.

Steps to Reproduce

elan run nightly lean -f

Expected behavior:
Identical output to lean --features

Actual behavior:

/home/james/.elan/toolchains/nightly/bin/lean: invalid option -- 'f'
Unknown command line option
Lean (version 4.12.0-nightly-2024-10-12, x86_64-unknown-linux-gnu, commit a3bc4d235961, Release)
Miscellaneous:
...

Versions

Output of elan run nightly lean -v
Lean (version 4.12.0-nightly-2024-10-12, x86_64-unknown-linux-gnu, commit a3bc4d2, Release)

OS Version: Ubuntu 22.04.3 LTS

Impact

Minimal to no impact, just an inconsistency between information in the help command and actual behavior.

@James-Oswald James-Oswald added the bug Something isn't working label Oct 12, 2024
@nomeata
Copy link
Collaborator

nomeata commented Oct 12, 2024

Thanks for raising this. Care to make a PR that adjusts the help string to reality? Probably the easiest course of action. Ideally before any bike shedding about the CLI interface ensues :-)

github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2024
Closes #5682

- Removes the broken `-f` flag from the help message which doesn't
behave as expected as an alternative to `--features`.
- Adds the `-g` flag to the help message which is a working alternative
to the `--githash` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants