Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused -static-libgcc MinGW linker arg #6535

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix: remove unused -static-libgcc MinGW linker arg #6535

merged 1 commit into from
Jan 5, 2025

Conversation

Kha
Copy link
Member

@Kha Kha commented Jan 5, 2025

This PR avoids a linker warning on Windows.

The argument may have been superfluous ever since the initial implementation.

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Jan 5, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 5, 2025 17:08 Inactive
@Kha Kha added the changelog-compiler Compiler, runtime, and FFI label Jan 5, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 5, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 5, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6535
4774a6d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 5, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6535
7625760
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 5, 2025
@Kha Kha added this pull request to the merge queue Jan 5, 2025
@kim-em
Copy link
Collaborator

kim-em commented Jan 5, 2025

Can confirm this avoids the

clang: warning: argument unused during compilation: '-static-libgcc' [-Wunused-command-line-argument]

warning experience on v4.16.0-rc1 by Windows users of Mathlib.

Merged via the queue into master with commit 76f883b Jan 5, 2025
33 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 5, 2025
@Kha @github-actions
fix: remove unused -static-libgcc MinGW linker arg (#6535)
60fb1ca 
This PR avoids a linker warning on Windows.

The argument may have been superfluous ever since the initial
implementation.

(cherry picked from commit 76f883b)
@github-actions github-actions bot mentioned this pull request Jan 5, 2025
Merged
kim-em pushed a commit that referenced this pull request Jan 6, 2025
@Kha @kim-em
fix: remove unused -static-libgcc MinGW linker arg (#6535)
3202715 
This PR avoids a linker warning on Windows.

The argument may have been superfluous ever since the initial
implementation.

(cherry picked from commit 76f883b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.16.0 builds-mathlib CI has verified that Mathlib builds against this PR changelog-compiler Compiler, runtime, and FFI release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-community-bot @kim-em