Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: explain app_delab #6450

Merged
merged 2 commits into from
Dec 29, 2024
Merged

doc: explain app_delab #6450

merged 2 commits into from
Dec 29, 2024

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 26, 2024 •
edited by kmill
Loading

This PR adds a docstring to the @[app_delab] attribute.

@eric-wieser eric-wieser marked this pull request as ready for review December 26, 2024 00:56
@eric-wieser eric-wieser requested a review from kmill as a code owner December 26, 2024 00:56
@eric-wieser eric-wieser mentioned this pull request Dec 26, 2024
Closed
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 26, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 26, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0ebe9e5ba3c1603cb42f1180a6584bf130ae6ce5 --onto f9f8abe2a3eb0591cef3769e2a51717fb2b9a166. (2024-12-26 01:16:09)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0ebe9e5ba3c1603cb42f1180a6584bf130ae6ce5 --onto fe45ddd6105078a0a3bd855e5d94673e794f6b88. (2024-12-28 17:38:40)

mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 28, 2024
@eric-wieser
chore: use app_delab (#20249)
aa72692 
This has the same behavior as `delab app.`, but protects against typos.

The feature appeared in leanprover/lean4#4976, though won't be documented until leanprover/lean4#6450.
@kmill kmill added this pull request to the merge queue Dec 29, 2024
@kmill kmill removed this pull request from the merge queue due to a manual request Dec 29, 2024
@kmill kmill added the changelog-doc Documentation label Dec 29, 2024
@kmill kmill enabled auto-merge December 29, 2024 15:06
@kmill kmill added this pull request to the merge queue Dec 29, 2024
Merged via the queue into leanprover:master with commit 11eea84 Dec 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill left review comments

Assignees
No one assigned
Labels
changelog-doc Documentation toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @leanprover-community-bot @kmill