-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improve DocsExample
visual output and API
#845
Comments
Hi @MisRob, I’ve added the tabs feature as suggested, allowing users to switch between HTML, JS, and SCSS. If there’s only one tab, the tab options won’t be shown. I’ve also attached a video for reference. Could you please assign this task to me? Looking forward to your feedback |
Hi @chetan21122004, thanks a lot! It looks very well. As mentioned in the issue, this is a proposal stage, so the requirements may be subject to change. I'm currently confirming details with the team. After I finalize this issue by the end of next week, I'm happy to assign this to you - you're doing great with the task no.1 #836! There's much more to come in this area so keep an eye if you're interested. Meanwhile you're welcome to find issues that are ready for contribution, marked with 'help wanted'. |
Hi @chetan21122004, we seem to be in agreement that the proposal above is desired. I can get you assigned if you'd like to. I'd ask you to keep this work separate from #836 and open a new pull request for this update after we finish review and merge #836. Let me know! Also is the amount of detail in the issue clear or should I add something? |
DocsExample
visual output and APIDocsExample
visual output and API
Actually @chetan21122004 let me assign you so it's reserved for you as you already have that work, but if you don't wish to work on it anymore, let us know and we will unassign |
Lovely, thanks @chetan21122004. I think after @ozer550 finishes reviewing #836, I would give it one last look, and then you could start addressing this follow-up in a new branch. Looking forward to further collaboration. |
Hi @chetan21122004, I wanted to mention that Learning Equality will be closed from December 23 to January 5. Feel free to slowly work on this in a new branch after you have resolved the feedback on the current PR - I think you already have a good sense of this task. See you later in January! |
Hi @MisRob, thank you for the update. I’ll start working on this in a new branch after addressing the feedback on my current PR. Your guidance has been incredibly helpful, and I’ll ensure to maintain quality. Wishing you and the team a joyful Christmas and a wonderful holiday season. Looking forward to collaborating further in January! |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Background
The first version of
DocsExample
requiresDocsShow
being passed viacode
slot:Visually, all code snippets are displayed above the example.
Addresses
This proposal aims at improving
Proposal
(1) Remove the need for passing
DocsShowCode
toDocsExample
html
,javascript
, andscss
slotsDocsExample
will useDocsShowCode
internally to render these slots(2)
DocsExample
shows a toolbar on the left with the option to switch the view of the code between HTML, Javascript, and CSS.would output very similar experience to Vuetify's:
The text was updated successfully, but these errors were encountered: