From 3bfb8a3bb6a18b1b67774b8eb1751c44518bb797 Mon Sep 17 00:00:00 2001 From: whitzhu Date: Thu, 28 Jul 2016 15:47:09 -0700 Subject: [PATCH 1/3] Updated Explore Topic Card into lists --- .../assets/src/vue/explore-page/index.vue | 5 +- .../plugins/learn/assets/src/vue/learn.styl | 8 +++ .../learn/assets/src/vue/list-grid/index.vue | 69 +++++++++++++++++++ .../learn/assets/src/vue/list/index.vue | 68 ++++++++++++++++++ .../learn/assets/src/vue/topic-card/index.vue | 10 +-- 5 files changed, 154 insertions(+), 6 deletions(-) create mode 100644 kolibri/plugins/learn/assets/src/vue/list-grid/index.vue create mode 100644 kolibri/plugins/learn/assets/src/vue/list/index.vue diff --git a/kolibri/plugins/learn/assets/src/vue/explore-page/index.vue b/kolibri/plugins/learn/assets/src/vue/explore-page/index.vue index 3b49362c851..af2a54c0dae 100644 --- a/kolibri/plugins/learn/assets/src/vue/explore-page/index.vue +++ b/kolibri/plugins/learn/assets/src/vue/explore-page/index.vue @@ -21,7 +21,7 @@ You can navigate groups of content through headings. - + - + + +
+

{{header}}

+
+ +
+
+ + + + + + + + + + + diff --git a/kolibri/plugins/learn/assets/src/vue/list/index.vue b/kolibri/plugins/learn/assets/src/vue/list/index.vue new file mode 100644 index 00000000000..8f6b9050b91 --- /dev/null +++ b/kolibri/plugins/learn/assets/src/vue/list/index.vue @@ -0,0 +1,68 @@ + + + + + + + diff --git a/kolibri/plugins/learn/assets/src/vue/topic-card/index.vue b/kolibri/plugins/learn/assets/src/vue/topic-card/index.vue index d3a1ab3c8cd..c1b5859e6ee 100644 --- a/kolibri/plugins/learn/assets/src/vue/topic-card/index.vue +++ b/kolibri/plugins/learn/assets/src/vue/topic-card/index.vue @@ -1,9 +1,9 @@ @@ -15,7 +15,7 @@ module.exports = { components: { - card: require('../card'), + list: require('../list'), }, props: { id: { @@ -43,12 +43,14 @@ From 52408cd0c1887cb78d5893577d40c6a1c17e3135 Mon Sep 17 00:00:00 2001 From: indirectlylit Date: Fri, 29 Jul 2016 09:50:51 -0700 Subject: [PATCH 2/3] naming refactor --- .../{card => card-grid/grid-item}/index.vue | 2 +- .../vue/{list-grid => card-list}/index.vue | 6 +++--- .../{list => card-list/list-item}/index.vue | 2 +- .../images/default_thumbnail.png | Bin .../index.vue | 6 +++--- .../src/vue/expandable-content-grid/index.vue | 6 +++--- .../assets/src/vue/explore-page/index.vue | 18 +++++++++--------- .../assets/src/vue/search-widget/index.vue | 12 ++++++------ .../{topic-card => topic-list-item}/index.vue | 6 +++--- 9 files changed, 29 insertions(+), 29 deletions(-) rename kolibri/plugins/learn/assets/src/vue/{card => card-grid/grid-item}/index.vue (96%) rename kolibri/plugins/learn/assets/src/vue/{list-grid => card-list}/index.vue (95%) rename kolibri/plugins/learn/assets/src/vue/{list => card-list/list-item}/index.vue (97%) rename kolibri/plugins/learn/assets/src/vue/{content-card => content-grid-item}/images/default_thumbnail.png (100%) rename kolibri/plugins/learn/assets/src/vue/{content-card => content-grid-item}/index.vue (95%) rename kolibri/plugins/learn/assets/src/vue/{topic-card => topic-list-item}/index.vue (88%) diff --git a/kolibri/plugins/learn/assets/src/vue/card/index.vue b/kolibri/plugins/learn/assets/src/vue/card-grid/grid-item/index.vue similarity index 96% rename from kolibri/plugins/learn/assets/src/vue/card/index.vue rename to kolibri/plugins/learn/assets/src/vue/card-grid/grid-item/index.vue index 9a61b6b3885..134836556b3 100644 --- a/kolibri/plugins/learn/assets/src/vue/card/index.vue +++ b/kolibri/plugins/learn/assets/src/vue/card-grid/grid-item/index.vue @@ -29,7 +29,7 @@ diff --git a/kolibri/plugins/learn/assets/src/vue/list/index.vue b/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue similarity index 97% rename from kolibri/plugins/learn/assets/src/vue/list/index.vue rename to kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue index 8f6b9050b91..8a91f6d5eb0 100644 --- a/kolibri/plugins/learn/assets/src/vue/list/index.vue +++ b/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue @@ -29,7 +29,7 @@ - + diff --git a/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue b/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue index 8a91f6d5eb0..51cb4bde1d3 100644 --- a/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue +++ b/kolibri/plugins/learn/assets/src/vue/card-list/list-item/index.vue @@ -30,39 +30,40 @@ @require '~core-theme.styl' @require '../../learn.styl' + @require 'jeet' - $thumb-width = 60px + $min-height = 60px // min card height .root + position: relative display: block - width: $list-width - height: $list-height + min-height: 60px background-color: $core-bg-light - overflow: hidden border-radius: $radius + display: table + width: 100% .thumb-wrapper - position: relative - display: block - float: left - width: $thumb-width - height: $list-height - border-radius: $radius 0 0 $radius - overflow: hidden + position: absolute + left: 0.4em + width: $min-height + height: $min-height + border-radius: $radius 0 0 $radius .text position: relative - display: block width: 100% - height: $list-height - padding: 0.6em font-size: 0.9rem font-weight: bold color: $core-text-default + display: table-row .title - position: absolute - top: 50% - transform: translateY(-50%) + display: table-cell + width: 100% + height: 100% + padding: 0.8em + padding-left: $min-height + vertical-align: middle diff --git a/kolibri/plugins/learn/assets/src/vue/learn.styl b/kolibri/plugins/learn/assets/src/vue/learn.styl index 82f9a1c327e..adcc692c97a 100644 --- a/kolibri/plugins/learn/assets/src/vue/learn.styl +++ b/kolibri/plugins/learn/assets/src/vue/learn.styl @@ -11,18 +11,11 @@ $n-cols-array = 1 2 3 4 5 // possible numbers of columns $left-margin = 100px $right-margin = 25px -$list-height = 60px // fixed card height -$list-width = 100% // fixed card width -$list-gutter = 20px -$n-cols-list-array = 1 // compute the target grid width based on the number of columns grid-width($n-cols) ($card-width * $n-cols) + ($card-gutter * ($n-cols + 1)) -grid-list-width($n-cols) - ($list-width * $n-cols) + ($list-gutter * ($n-cols + 1)) - $portrait-breakpoint = $left-margin * 2 + grid-width(1) + $right-margin // compute the media query breakpoint, based on the target grid width