Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntryCounts.unread/unimportant #283

Open
lemon24 opened this issue Jul 9, 2022 · 4 comments
Open

EntryCounts.unread/unimportant #283

lemon24 opened this issue Jul 9, 2022 · 4 comments

Comments

@lemon24
Copy link
Owner

lemon24 commented Jul 9, 2022

'important': lambda counts: counts.important,
# TODO: an unread/unimportant property would be nice
'unread': lambda counts: counts.total - counts.read,
# TODO: if we keep these average intervals, properties for them might be nice too
'avg1m': lambda counts: counts.averages[0],
'avg3m': lambda counts: counts.averages[1],
'avg1y': lambda counts: counts.averages[2],

Also useful here: dbrennand/Feederbot#16

@lemon24
Copy link
Owner Author

lemon24 commented Apr 6, 2024

Some 2024 notes:

  1. Now that Entry.important is tri-state (bool or None), .unimportant cannot be a total - important property anymore, it needs to come from the database; "unimportant" means important == False, because that's what mark_entry_as_unimportant() defines it as.
  2. The same fields/properties should be added to EntrySearchCounts.
  3. The avg{1m,3m,1y} properties can be ignored for now, following the work in Am I interacting with this feed? #254 (comment) / this gist / Web app? is slow #306 (comment) I am relatively convinced the averages API is not powerful enough, and should be deprecated in 4.0.

@lemon24
Copy link
Owner Author

lemon24 commented Jun 23, 2024

Remaining work: add unread property (I mistitled c867823).

@JCart97
Copy link

JCart97 commented Jul 22, 2024

Remaining work: add unread property (I mistitled c867823).

Looking at this issue - by the latest comment, do you mean adding unread to the src/reader/types.py file?

@lemon24
Copy link
Owner Author

lemon24 commented Jul 22, 2024

Looking at this issue - by the latest comment, do you mean adding unread to the src/reader/types.py file?

Yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants