Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove future when the query raises an error #6

Open
leoasis opened this issue Apr 30, 2013 · 2 comments
Open

Remove future when the query raises an error #6

leoasis opened this issue Apr 30, 2013 · 2 comments
Labels

Comments

@leoasis
Copy link
Owner

leoasis commented Apr 30, 2013

When the query raises an error, remove the future from the list, so that it does not get called again when triggering another future

@leoasis
Copy link
Owner Author

leoasis commented May 13, 2013

The problem here is that we don't know which query is the problematic, since we execute all at once.

@leoasis
Copy link
Owner Author

leoasis commented Jun 18, 2013

Still, having the problematic queries execute again for next futures won't help, so perhaps the best solution would be to clear the futures queue.

Anyway, common practice to handle errors from db is to clean up, and either start over or just present an error to the user. In any case, no further action should be made with the current transaction, if any, and it must be rollbacked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant