👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@PaitoAnderson Thank you for submitting this PR!

🔔 @koss-lebedev - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

hi @PaitoAnderson , what is the benefit of this approach over using an enum? The enum is exported, so you can safely import PlayStatus and use its values

While the typing works, I got a runtime error of Uncaught TypeError: Cannot read property 'Playing' of undefined.

import ReactSound, { PlayStatus } from 'react-sound';
<ReactSound url="/sounds/sample.mp3" playStatus={PlayStatus.Playing} />

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@koss-lebedev if the enum declaration in the typings doesn't reflect an export of the underlying code (which it appears not to), it won't work at runtime (when the typings aren't available).

@PaitoAnderson Thank you for submitting this PR!

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

🔔 @koss-lebedev - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "pr_number": 40592,
  "author": "PaitoAnderson",
  "owners": [
    "koss-lebedev",
    "PaitoAnderson"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "761cd68",
  "headCommitOid": "761cd68cf4ca6b20839c13fd0350eb53a11385b3",
  "mergeIsRequested": false,
  "stalenessInDays": null,
  "lastCommitDate": "1970-01-01T00:00:00.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40592/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "react-sound"
  ],
  "files": [
    {
      "filePath": "types/react-sound/index.d.ts",
      "kind": "definition",
      "package": "react-sound"
    },
    {
      "filePath": "types/react-sound/react-sound-tests.tsx",
      "kind": "package-meta",
      "package": "react-sound"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 1,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 4,
  "isChangesRequested": false
}

@PaitoAnderson Everything looks good here. Great job! I am ready to merge this PR on your behalf.
If you'd like that to happen, please post a comment with the exact text

Ready to merge

and I'll merge it the next time I look at this PR.