diff --git a/lib/lgtm/error_handleable.rb b/lib/lgtm/error_handleable.rb index ab6810a..188d528 100644 --- a/lib/lgtm/error_handleable.rb +++ b/lib/lgtm/error_handleable.rb @@ -15,6 +15,11 @@ module ErrorHandleable Net::HTTPGatewayTimeOut ].freeze + # validate_response is response validationg + # @param [Net::HTTPxxx] response Net::HTTP responses + # @raise ::Lgtm::Errors::UnexpectedError + # @return [void] + # def validate_response(response) case response when *SERVER_ERRORS diff --git a/lib/lgtm/plugin.rb b/lib/lgtm/plugin.rb index 0c074bc..e1dbed7 100644 --- a/lib/lgtm/plugin.rb +++ b/lib/lgtm/plugin.rb @@ -24,11 +24,10 @@ class DangerLgtm < Plugin # Check status report, say lgtm if no violations # Generates a `markdown` of a lgtm image. # - # @param [image_url] lgtm image url - # @param [https_image_only] fetching https image only if true + # @param [String] image_url lgtm image url + # @param [Boolean] https_image_only https image only if true # # @return [void] - # def check_lgtm(image_url: nil, https_image_only: false) return unless status_report[:errors].length.zero? && status_report[:warnings].length.zero?