You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 3, 2019. It is now read-only.
When remote redis goes down, client will receive a on_disconnect event, and throw a
ConnectionError("Socket closed on remote end")
but when redis goes up, and we try to redo our previous actions, we will be blocked at
client.py 1290: yield gen.Task(self.connection.wait_until_ready)
the callback will never be called, hence we can't automatically recover from failure cases.
I fix this issue by add two lines(321,322)
318 def on_disconnect(self):
319 if self.subscribed:
320 self.subscribed = set()
321 if self.connection:
322 self.connection.disconnect()
323 raise ConnectionError("Socket closed on remote end")
When we are disconnected from remote server, we need to disconnect locally, so we won't be blocked for the previous failed unfinished request.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When remote redis goes down, client will receive a on_disconnect event, and throw a
ConnectionError("Socket closed on remote end")
but when redis goes up, and we try to redo our previous actions, we will be blocked at
client.py 1290: yield gen.Task(self.connection.wait_until_ready)
the callback will never be called, hence we can't automatically recover from failure cases.
I fix this issue by add two lines(321,322)
318 def on_disconnect(self):
319 if self.subscribed:
320 self.subscribed = set()
321 if self.connection:
322 self.connection.disconnect()
323 raise ConnectionError("Socket closed on remote end")
When we are disconnected from remote server, we need to disconnect locally, so we won't be blocked for the previous failed unfinished request.
The text was updated successfully, but these errors were encountered: