Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu entry #2

Open
hashhar opened this issue Aug 25, 2016 · 4 comments
Open

Add a context menu entry #2

hashhar opened this issue Aug 25, 2016 · 4 comments

Comments

@hashhar
Copy link

hashhar commented Aug 25, 2016

See microsoft/vscode#9213 for what I mean.

I even sent a PR but it seems such things are better suited in extensions.
If you would like I can submit a PR to your extension too.

@lfurzewaddock
Copy link
Owner

@hashhar I would be happy to integrate new functionality as long as it doesn't upset the default behaviour (open active file in default app). Any other functionality should be on an opt in basis using the Workspace/User Settings JSON.

My extension is written in JavaScript ES5, but should be fairly easy to accommodate the JavaScript your TypeScript generates (ES5, rather then ES6/2015).

@hashhar
Copy link
Author

hashhar commented Aug 26, 2016

@lfurzewaddock Okay. I'll try and get a PR ready within the week.

@InDIOS
Copy link

InDIOS commented Sep 5, 2016

Hi, i has implemented this feature, just take a look to the screenshots below and tell me what do you think about it. If the answer is positive, i'll be happy to do the corresponding PR.

Editor Context Menu:
editor-context

Explorer Context Menu
explorer-context

@lfurzewaddock
Copy link
Owner

@InDIOS looks good 👍 Submit a pull request in JavaScript ES5 and I'll merge it. I'm away for a break, so no rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants