Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Accept reactions as an approval #31

Open
bdougherty opened this issue Jul 11, 2016 · 2 comments
Open

Accept reactions as an approval #31

bdougherty opened this issue Jul 11, 2016 · 2 comments

Comments

@bdougherty
Copy link

Would be cool to support reactions to the initial PR comment instead of adding a new comment.

https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments

@bradrydzewski
Copy link
Member

bradrydzewski commented Jul 11, 2016

github added a preview for the new reactions API not too long ago:
https://developer.github.com/changes/2016-05-12-reactions-api-preview/

I'm not actively adding new features to lgtm (it is not abandoned, I just have some larger and more demanding open source projects I need to focus on right now) but am open to a pull request for this specific feature. The pull request would probably have to include:

  1. ability to enable reactions via the .lgtm file
  2. if enabled, make the API call to get all reactions for the parent issue/comment
  3. calculate approvals based on reactions instead of comment text

We probably need to specify the limitation that the reactions would need to come from the parent comment, since making an API call for each individual comment to get the reactions is probably not viable due to API throttling, and to some lesser extent resource utilization.

Definitely open to the idea.

@bradrydzewski
Copy link
Member

bradrydzewski commented Jul 11, 2016

note that we also need to see if GitHub provides a hook for reactions. Right now I don't see any documentation that reactions trigger a hook which would be required to notify LGTM
https://developer.github.com/v3/activity/events/types/

I didn't look exhaustively but will do some more research and post back here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants