Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

LGTM comment followed by commit+comment results in passing status #40

Open
BrianHarboldt opened this issue Aug 12, 2016 · 2 comments
Open

LGTM comment followed by commit+comment results in passing status #40

BrianHarboldt opened this issue Aug 12, 2016 · 2 comments

Comments

@BrianHarboldt
Copy link

Once a PR is signed off, additional commits can be added and any comment made on the PR will trigger the PR as signed off again.

  1. Commits made, PR opened:
    image
  2. Maintainer signs off on PR:
    image
  3. A new commit is made to the PR. The status goes to yellow.
  4. Anybody makes a comment and the status goes to green.
    image

Github overview
image
@drusellers
Copy link

👍

@jonbodner
Copy link

If you are self-hosting, this is fixed on our fork at https://github.com/lgtmeow/lgtmeow

@Dattaya Dattaya mentioned this issue Nov 8, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drusellers @jonbodner @BrianHarboldt