Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate logging #11

Open
matpatterson opened this issue Apr 22, 2021 · 11 comments
Open

Duplicate logging #11

matpatterson opened this issue Apr 22, 2021 · 11 comments

Comments

@matpatterson
Copy link

Screen Shot 2021-04-23 at 8 16 53 am

Screen Shot 2021-04-23 at 8 18 14 am

The same completed items are pulled in multiple times for me. Any troubleshooting suggestions?

@liamcain
Copy link
Owner

liamcain commented Apr 28, 2021

@matpatterson, why does your heading say ## COMPLETED and the section setting has ## Completed? Could you try changing the text to match exactly and see if the issue persists?

I'll see if I can reproduce the issue locally.

@matpatterson
Copy link
Author

matpatterson commented Apr 28, 2021 via email

@liamcain
Copy link
Owner

That’s just CSS changing the presentation, the file itself matches the case

Aah, okay. We can rule that out then.


I was able to reproduce the issue by adding a trailing space to the sectionHeading (so ## Completed vs ## Completed).

I just released v0.1.11 with a fix for this issue. Can you check if you still seeing the duplicate logging on the latest version?

@matpatterson
Copy link
Author

Updated to the latest version, and checked there is no whitespace after the section heading, but unfortunately it is still happening.
Screen Shot 2021-04-29 at 8 19 51 am

@liamcain
Copy link
Owner

🤦 Okay, I figured out the issue. I wasn't properly handling custom section headings. The latest version (0.1.12) should solve the real issue.

Sorry about that and thank you for your patience 🙏

@matpatterson
Copy link
Author

Thanks for your work - I've updated to the latest but it is still duplicating for me. If you need other troubleshooting details from me, let me know.

I tried removing and re-adding the plugin just in case, but no improvement there.

@liamcain
Copy link
Owner

😢 That's very disappointing. I'm unable to reproduce the issue on my end. Could you send me the contents of your plugin settings file? It should be located at <Your Vault>/.obsidian/plugins/things-logbook/data.json

@matpatterson
Copy link
Author

{"hasAcceptedDisclaimer":true,"latestSyncTime":1619666241,"isSyncEnabled":true,"syncInterval":1800,"sectionHeading":"## Completed","tagPrefix":"logbook/"}

@matpatterson
Copy link
Author

I have a guess this is something to do with Obsidian syncing between my devices and the plugin settings not being the same everywhere, because I am now seeing the daily page update with both "Logbook" and "Completed" headings - three x Completed in a row, then one Logbook.

So maybe each device is doing its own update independently.

@liamcain
Copy link
Owner

liamcain commented May 3, 2021

I wasn't able to reproduce the issue with the settings configuration that you provided, but I hadn't considered that you were syncing from multiple devices.

I have a guess this is something to do with Obsidian syncing between my devices and the plugin settings not being the same everywhere, because I am now seeing the daily page update with both "Logbook" and "Completed" headings - three x Completed in a row, then one Logbook.

So maybe each device is doing its own update independently.

Aah, interesting. It's possible my initial hunch was right then and one of the device settings had a trailing space (so they didn't match exactly). Once all your devices have the same Section Heading, can you confirm whether or not the issue is resolved?

@matpatterson
Copy link
Author

It's very strange - I have removed that plugin from the laptop, and closed Obsidian on that device too. So just the desktop has the plugin enabled now. The desktop I have changed to use ## Logbook

and yet, somehow it is still pulling out ## Completed...

Screen Shot 2021-05-04 at 9 42 23 am

Screen Shot 2021-05-04 at 9 42 19 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants