Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Sync on DB #27

Open
42sol-eu opened this issue Nov 18, 2021 · 0 comments
Open

No Sync on DB #27

42sol-eu opened this issue Nov 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@42sol-eu
Copy link

42sol-eu commented Nov 18, 2021

Before Submitting: Double-check that you are running the latest version of the plugin. The bug might have already been fixed 😄

Describe the bug

A fetch of 0 tasks updates the sync time (this is fine if there are no tasks).
A failed access (maybe on iOS) returns 0 tasks fetched.

After one failed call (this might be a call on winOS or iOS) the sync time (this.options.latestSyncTime) will be set to the active timestamp and new syncs will not fetch any old tasks.

This comes from here:

async syncLogbook() {
        const logbookRenderer = new LogbookRenderer(this.app, this.options);
        const dailyNotes = getAllDailyNotes_1();
        const latestSyncTime = this.options.latestSyncTime || 0;

Steps to reproduce

I fixed my problem by a hard reset of the latestSyncTime, replacing the initialisation of latestSyncTime

const latestSyncTime = 0;

And reinserting the correct code afterwards.

Expected behavior

  • maybe add a function for initial sync or reset last sync time.
  • check for OS-version and do not update the last synced time ...
  • maybe do not update last sync time if no task was fetched (if the error condition could not be made visible in the code)

Environment (please specify)

OS

macOS

Obsidian Version (e.g. v0.10.6)

- Things3
	- Version: 3.15.7 (31507503)
- Obsidan 
	- Version: 0.12.19
@42sol-eu 42sol-eu added the bug Something isn't working label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant