Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use functional options to construct the Routing Table #89

Open
aarshkshah1992 opened this issue Jun 3, 2020 · 0 comments
Open

Use functional options to construct the Routing Table #89

aarshkshah1992 opened this issue Jun 3, 2020 · 0 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@aarshkshah1992
Copy link
Contributor

We've begun to pass in some constructor arguments as nil if we don't need them. It's time to introduce functional options to the Routing Table.
@aarshkshah1992 aarshkshah1992 added the kind/enhancement A net-new feature or improvement to an existing feature label Jun 3, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue Jun 3, 2020
Merged
xprazak2 added a commit to xprazak2/go-libp2p-kbucket that referenced this issue Jun 12, 2021
@xprazak2
Fixes libp2p#89 - Use functional opts to create Routing Table
6b63ba2
xprazak2 added a commit to xprazak2/go-libp2p-kbucket that referenced this issue Jun 12, 2021
@xprazak2
Fixes libp2p#89 - Use functional opts to create Routing Table
1ee9497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aarshkshah1992