Skip to content

Commit 8222461

Browse files
authored
chore: replace async-std with tokio in autonat tests (#5671)
## Description ref #4449 Refactored `autonat` tests to use `tokio` instead of `async-std`.
1 parent 0c34d9f commit 8222461

File tree

4 files changed

+28
-26
lines changed

4 files changed

+28
-26
lines changed

Cargo.lock

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protocols/autonat/Cargo.toml

+7-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ edition = "2021"
44
rust-version = { workspace = true }
55
description = "NAT and firewall detection for libp2p"
66
version = "0.13.1"
7-
authors = ["David Craven <[email protected]>", "Elena Frank <[email protected]>", "Hannes Furmans <[email protected]>"]
7+
authors = [
8+
"David Craven <[email protected]>",
9+
"Elena Frank <[email protected]>",
10+
"Hannes Furmans <[email protected]>",
11+
]
812
license = "MIT"
913
repository = "https://github.com/libp2p/rust-libp2p"
1014
keywords = ["peer-to-peer", "libp2p", "networking"]
@@ -32,12 +36,11 @@ rand_core = { version = "0.6", optional = true }
3236
thiserror = { version = "1.0.52", optional = true }
3337

3438
[dev-dependencies]
35-
tokio = { version = "1", features = ["macros", "rt", "sync"]}
36-
async-std = { version = "1.10", features = ["attributes"] }
39+
tokio = { workspace = true, features = ["macros", "rt", "sync"] }
3740
libp2p-swarm-test = { path = "../../swarm-test" }
3841
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
3942
libp2p-identify = { workspace = true }
40-
libp2p-swarm = { workspace = true, features = ["macros"]}
43+
libp2p-swarm = { workspace = true, features = ["macros"] }
4144

4245
[features]
4346
default = ["v1", "v2"]

protocols/autonat/tests/test_client.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
1919
// DEALINGS IN THE SOFTWARE.
2020

21-
use async_std::task::JoinHandle;
2221
use libp2p_autonat::{
2322
Behaviour, Config, Event, NatStatus, OutboundProbeError, OutboundProbeEvent, ResponseError,
2423
};
@@ -27,12 +26,13 @@ use libp2p_identity::PeerId;
2726
use libp2p_swarm::{Swarm, SwarmEvent};
2827
use libp2p_swarm_test::SwarmExt as _;
2928
use std::time::Duration;
29+
use tokio::task::JoinHandle;
3030

3131
const MAX_CONFIDENCE: usize = 3;
3232
const TEST_RETRY_INTERVAL: Duration = Duration::from_secs(1);
3333
const TEST_REFRESH_INTERVAL: Duration = Duration::from_secs(2);
3434

35-
#[async_std::test]
35+
#[tokio::test]
3636
async fn test_auto_probe() {
3737
let mut client = Swarm::new_ephemeral(|key| {
3838
Behaviour::new(
@@ -133,7 +133,7 @@ async fn test_auto_probe() {
133133
assert!(client.behaviour().public_address().is_some());
134134
}
135135

136-
#[async_std::test]
136+
#[tokio::test]
137137
async fn test_confidence() {
138138
let mut client = Swarm::new_ephemeral(|key| {
139139
Behaviour::new(
@@ -217,7 +217,7 @@ async fn test_confidence() {
217217
}
218218
}
219219

220-
#[async_std::test]
220+
#[tokio::test]
221221
async fn test_throttle_server_period() {
222222
let mut client = Swarm::new_ephemeral(|key| {
223223
Behaviour::new(
@@ -268,7 +268,7 @@ async fn test_throttle_server_period() {
268268
assert_eq!(client.behaviour().confidence(), 0);
269269
}
270270

271-
#[async_std::test]
271+
#[tokio::test]
272272
async fn test_use_connected_as_server() {
273273
let mut client = Swarm::new_ephemeral(|key| {
274274
Behaviour::new(
@@ -306,7 +306,7 @@ async fn test_use_connected_as_server() {
306306
}
307307
}
308308

309-
#[async_std::test]
309+
#[tokio::test]
310310
async fn test_outbound_failure() {
311311
let mut client = Swarm::new_ephemeral(|key| {
312312
Behaviour::new(
@@ -351,7 +351,7 @@ async fn test_outbound_failure() {
351351
let mut inactive_servers = Vec::new();
352352

353353
for (id, handle) in servers.split_off(1) {
354-
handle.cancel().await;
354+
handle.abort();
355355
inactive_servers.push(id);
356356
}
357357

@@ -375,7 +375,7 @@ async fn test_outbound_failure() {
375375
}
376376
}
377377

378-
#[async_std::test]
378+
#[tokio::test]
379379
async fn test_global_ips_config() {
380380
let mut client = Swarm::new_ephemeral(|key| {
381381
Behaviour::new(
@@ -426,7 +426,7 @@ async fn new_server_swarm() -> (PeerId, Multiaddr, JoinHandle<()>) {
426426
let (_, multiaddr) = swarm.listen().await;
427427
let peer_id = *swarm.local_peer_id();
428428

429-
let task = async_std::task::spawn(swarm.loop_on_next());
429+
let task = tokio::spawn(swarm.loop_on_next());
430430

431431
(peer_id, multiaddr, task)
432432
}

protocols/autonat/tests/test_server.rs

+12-12
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ use libp2p_swarm::{Swarm, SwarmEvent};
2828
use libp2p_swarm_test::SwarmExt as _;
2929
use std::{num::NonZeroU32, time::Duration};
3030

31-
#[async_std::test]
31+
#[tokio::test]
3232
async fn test_dial_back() {
3333
let (mut server, server_id, server_addr) = new_server_swarm(None).await;
3434
let (mut client, client_id) = new_client_swarm(server_id, server_addr).await;
3535
let (_, client_addr) = client.listen().await;
36-
async_std::task::spawn(client.loop_on_next());
36+
tokio::spawn(client.loop_on_next());
3737

3838
let client_port = client_addr
3939
.into_iter()
@@ -128,14 +128,14 @@ async fn test_dial_back() {
128128
}
129129
}
130130

131-
#[async_std::test]
131+
#[tokio::test]
132132
async fn test_dial_error() {
133133
let (mut server, server_id, server_addr) = new_server_swarm(None).await;
134134
let (mut client, client_id) = new_client_swarm(server_id, server_addr).await;
135135
client
136136
.behaviour_mut()
137137
.probe_address("/ip4/127.0.0.1/tcp/12345".parse().unwrap());
138-
async_std::task::spawn(client.loop_on_next());
138+
tokio::spawn(client.loop_on_next());
139139

140140
let request_probe_id = match server.next_behaviour_event().await {
141141
Event::InboundProbe(InboundProbeEvent::Request { peer, probe_id, .. }) => {
@@ -178,7 +178,7 @@ async fn test_dial_error() {
178178
}
179179
}
180180

181-
#[async_std::test]
181+
#[tokio::test]
182182
async fn test_throttle_global_max() {
183183
let (mut server, server_id, server_addr) = new_server_swarm(Some(Config {
184184
throttle_clients_global_max: 1,
@@ -190,7 +190,7 @@ async fn test_throttle_global_max() {
190190
for _ in 0..2 {
191191
let (mut client, _) = new_client_swarm(server_id, server_addr.clone()).await;
192192
client.listen().await;
193-
async_std::task::spawn(client.loop_on_next());
193+
tokio::spawn(client.loop_on_next());
194194
}
195195

196196
let (first_probe_id, first_peer_id) = match server.next_behaviour_event().await {
@@ -218,7 +218,7 @@ async fn test_throttle_global_max() {
218218
}
219219
}
220220

221-
#[async_std::test]
221+
#[tokio::test]
222222
async fn test_throttle_peer_max() {
223223
let (mut server, server_id, server_addr) = new_server_swarm(Some(Config {
224224
throttle_clients_peer_max: 1,
@@ -230,7 +230,7 @@ async fn test_throttle_peer_max() {
230230

231231
let (mut client, client_id) = new_client_swarm(server_id, server_addr.clone()).await;
232232
client.listen().await;
233-
async_std::task::spawn(client.loop_on_next());
233+
tokio::spawn(client.loop_on_next());
234234

235235
let first_probe_id = match server.next_behaviour_event().await {
236236
Event::InboundProbe(InboundProbeEvent::Request { peer, probe_id, .. }) => {
@@ -265,7 +265,7 @@ async fn test_throttle_peer_max() {
265265
};
266266
}
267267

268-
#[async_std::test]
268+
#[tokio::test]
269269
async fn test_dial_multiple_addr() {
270270
let (mut server, server_id, server_addr) = new_server_swarm(Some(Config {
271271
throttle_clients_peer_max: 1,
@@ -280,7 +280,7 @@ async fn test_dial_multiple_addr() {
280280
client
281281
.behaviour_mut()
282282
.probe_address("/ip4/127.0.0.1/tcp/12345".parse().unwrap());
283-
async_std::task::spawn(client.loop_on_next());
283+
tokio::spawn(client.loop_on_next());
284284

285285
let dial_addresses = match server.next_behaviour_event().await {
286286
Event::InboundProbe(InboundProbeEvent::Request {
@@ -327,7 +327,7 @@ async fn test_dial_multiple_addr() {
327327
}
328328
}
329329

330-
#[async_std::test]
330+
#[tokio::test]
331331
async fn test_global_ips_config() {
332332
let (mut server, server_id, server_addr) = new_server_swarm(Some(Config {
333333
// Enforce that only clients outside of the local network are qualified for dial-backs.
@@ -338,7 +338,7 @@ async fn test_global_ips_config() {
338338

339339
let (mut client, _) = new_client_swarm(server_id, server_addr.clone()).await;
340340
client.listen().await;
341-
async_std::task::spawn(client.loop_on_next());
341+
tokio::spawn(client.loop_on_next());
342342

343343
// Expect the probe to be refused as both peers run on the same machine and thus in the same local network.
344344
match server.next_behaviour_event().await {

0 commit comments

Comments
 (0)