Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update of actions/upload-artifact to v4 broke rust-libp2p interop tests #604

Open
jxs opened this issue Feb 4, 2025 · 5 comments
Open

update of actions/upload-artifact to v4 broke rust-libp2p interop tests #604

jxs opened this issue Feb 4, 2025 · 5 comments

Comments

@jxs
Copy link
Member

jxs commented Feb 4, 2025 •
edited
Loading

attached the raw logs: logs_33564659032.zip.
A brief search pointed me to this
@achingbrain
Copy link
Member

I think it may have broken the build-without-secrets CI job here too.

Weird that no CI was run on the PR that updated it: #601

cc @MarcoPolo

@MarcoPolo
Copy link
Contributor

Weird that no CI was run on the PR that updated it: #601

Hmm, that is surprising. I thought I had that passing at the time. I'll look now

@MarcoPolo
Copy link
Contributor

The workflow wasn't run when changes only happened on the workflow related files. This is fixed now in #607

@MarcoPolo
Copy link
Contributor

That PR should also fix your issue @jxs . You'll need to update your workflow file here https://github.com/libp2p/rust-libp2p/blob/master/.github/workflows/interop-test.yml#L37 to include the input test-results-suffix: ${{matrix.flavour}}.

@jxs jxs mentioned this issue Feb 5, 2025
Merged
mergify bot pushed a commit to libp2p/rust-libp2p that referenced this issue Feb 5, 2025
@jxs
chore(ci): fix interop tests
79a1001 
See libp2p/test-plans#604 for more info

Pull-Request: #5850.
@jxs
Copy link
Member Author

jxs commented Feb 5, 2025

Thanks Marco! Fixed on libp2p/rust-libp2p#5850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarcoPolo @achingbrain @jxs