Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filename in diagnostics when compiling HLSL is wrong #66

Open
namandixit opened this issue Dec 6, 2024 · 0 comments
Open

Filename in diagnostics when compiling HLSL is wrong #66

namandixit opened this issue Dec 6, 2024 · 0 comments

Comments

@namandixit
Copy link

namandixit commented Dec 6, 2024 •
edited
Loading

When compiling an HLSL file to SPIR-V, in case of a compile error, the diagnostics printed point to a hlsl.hlsl file when IDxcCompiler3::Compile is called with in-memory source code. This might be fixed by using the pSourceName parameter of IDxcUtils::BuildArguments.

Fixing it the naive way will break API again (as discussed in #65 (comment)), so waiting for that to be resolved before working on this.
@namandixit namandixit changed the title Filename in diagnostics when compiling HLSL in wrong Filename in diagnostics when compiling HLSL is wrong Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@namandixit