File tree 1 file changed +6
-0
lines changed
1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change 2
2
3
3
# Self Review
4
4
Have you reviewed every line of your changes by yourself?
5
+
5
6
# Test
6
7
Have you added enough test cases to cover the new feature or bug fix?
7
8
Also, add comments to describe your test cases.
9
+
8
10
# Naming
9
11
Do function names keep consistent with its behavior?
10
12
Is it easy to infer the function's behavior by its name?
13
+
11
14
# Comment
12
15
Is there any code that confuses the reviewer?
13
16
Add comments on them! You'll be asked to do so anyway.
14
17
Make sure there is no syntax or spelling error in your comments.
15
18
Some online syntax checking tools like Grammarly may be helpful.
19
+
16
20
# Refactor
17
21
Is there any way to refactor the code to make it more readable?
18
22
If the refactoring touches a lot of existing code, send another PR to do it.
23
+
19
24
# Single Purpose
20
25
Make sure the PR does only one thing and nothing else.
26
+
21
27
# Diff Size
22
28
Make sure the diff size is no more than 500, split it into small PRs if it is too large.
You can’t perform that action at this time.
0 commit comments