Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEurobisGrid, getEurobisPoints implement same variables as getEurobisData #6

Closed
LennertSchepers opened this issue May 8, 2020 · 3 comments
Assignees

Comments

@LennertSchepers
Copy link
Member

currently the getEurobisGrid and getEurobisPoints only can have the Aphia (and grid size) as input, but it should be good to have the same possibilities as the getEurobisData function:

  • geourl
  • aphiaid
  • speciesgroup
  • mrgid
  • startyear
  • endyear
  • type

and somewhere specify in the function/examples how they can retrieve from which datasets these data come from.

@LennertSchepers
Copy link
Member Author

@salvafern you removed the eurobis grid/points functions from the package?

@salvafern
Copy link
Collaborator

Yes I removed the functions of the old package. It was a quick fix to make the package be more robust towards the EBR workshop. I can restore the old functions of even better, write new ones. But I wonder if the grid functions are that necessary. In my opinion these are useful only as a visualization tool - therefore we should rather visualize via WMS.

I'm not sure we can offer all the possibilities to query on. There are some limitations with this layer. Better to discuss internally.

@salvafern
Copy link
Collaborator

To be continued in #22

As I said, the grid layers don't allow to query on all those filters. Only on dataset and aphiaid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants