-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing CometActors from page #1655
Comments
I'll be trying to do some deeper work on comet plumbing for the 3.2 cycle, time willing. I've got many other improvements in ideation/half-implemented stages, but it's going to take some time. I'd like to roll this in with those; if anyone else wants to pick it up, though, please feel free. |
This sounds interesting. I'd like to give it a shot unless you are already working on it. |
Go for it. My deeper work on comets got shelved in favor of #1876, which can't really go in until a major version bump… That kind of made me stumble in general, so those changes are still in nascent stage and won't be making it into 3.2. |
As per the discussion at https://groups.google.com/forum/#!topic/liftweb/u3qN8mVUpnI and as Antonio pointed out in that conversation, this is a feature which is likely to be multi-faceted.
Removing the CometActor from the client side only is probably simplest and provided via a function such as lift.stopListeningToComet as Antonio has suggested.
The other option is doing it on the server - a S.removeComet to correspond
to S.findOrCreateComet. That could do a lot better cleanup handling, including unsubscribing clients,
shutting down the comet immediately, and removing it from the session's comet list. On the flip side,
that would have to deal with potential timing issues with, say, clients in multiple tabs/windows that
have perhaps already sent something to the comet for processing, etc etc.
Even just a client side shutdown which would allow server side GC to kick in properly would be awesome by itself.
The text was updated successfully, but these errors were encountered: