Skip to content

FilesystemStore::list is not safe to call concurrently #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBlueMatt opened this issue May 23, 2025 · 1 comment · May be fixed by #3799
Open

FilesystemStore::list is not safe to call concurrently #3795

TheBlueMatt opened this issue May 23, 2025 · 1 comment · May be fixed by #3799
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

We can have a file/dir removed between fs::read_dir and dir_entry_is_key looks at its metadata which causes a spurious error. Obviously list will always return a set that may be bogus by the time its used, but that should be pretty clear from the API, the call shouldn't fail, however (and its probably okay that its internally-inconsistent).

@TheBlueMatt TheBlueMatt added this to the 0.2 milestone May 23, 2025
@tnull tnull linked a pull request May 24, 2025 that will close this issue
@tnull
Copy link
Contributor

tnull commented May 24, 2025

Tbh. I'm a bit hesistant to break the approach of bubbling up any IO error to the callsite and have them deal with it based on the context. However, I agree that if any, list can be a bit more relaxed, now opened #3799.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants