Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneded permissions #40

Open
ale5000-git opened this issue Jan 2, 2025 · 1 comment
Open

Unneded permissions #40

ale5000-git opened this issue Jan 2, 2025 · 1 comment
Labels
Won't fix This will not be worked on

Comments

@ale5000-git
Copy link

These are not needed:

      <permission name="android.permission.FOREGROUND_SERVICE"/>
      <permission name="android.permission.READ_CONTACTS"/>

in:
https://github.com/lineageos4microg/android_vendor_partner_gms/blob/master/GmsCore/privapp-permissions-com.google.android.gms.xml
as they aren't privileged permissions.

@petefoth
Copy link
Contributor

Thanks for your input.

These are not needed:

      <permission name="android.permission.FOREGROUND_SERVICE"/>
      <permission name="android.permission.READ_CONTACTS"/>

You may or may not be correct. When I was sorting out the mess around GmsCore permissions, I chose to follow the approach of IodeOS, and re-used much of their code. In particular the code in their privapp-permissions-com.google.android.gms.xml file which includes the two permissions you mention as being not needed.

The resulting builds seem to work. I do not have the time or resources (or motivation TBH) to make and test any changes in this area, unless something is clearly not working. Software can always be 'better'. The question - for me at least - is whether the costs and risks of making a change are significantly outweighed by the benefits gained.

If you, or anyone else, wanted to implement the change, and test that it doesn't break any GmsCore functionality on a selection of devices (e.g. at least one device running 22.0 build, one running 21.0, and one running 20.0), and document the tests, then I would consider a PR. But I would probably end up rejecting it because I don't see the point of changing something that isn't very broken. So I would suggest not spending any more time on this issue.

@petefoth petefoth added the Won't fix This will not be worked on label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants