fix attachment url pattern

Author: HighKo

kotlin-insight-client/kotlin-insight-client-sdk/src/main/kotlin/com/linkedplanet/kotlininsightclient/sdk/SdkInsightAttachmentOperator.kt

@@ -22,6 +22,7 @@ package com.linkedplanet.kotlininsightclient.sdk
 import arrow.core.Either
 import arrow.core.raise.either
 import com.linkedplanet.kotlininsightclient.api.error.InsightClientError
+import com.linkedplanet.kotlininsightclient.api.error.OtherNotFoundError
 import com.linkedplanet.kotlininsightclient.api.interfaces.InsightAttachmentOperator
 import com.linkedplanet.kotlininsightclient.api.model.AttachmentId
 import com.linkedplanet.kotlininsightclient.api.model.InsightAttachment
@@ -66,13 +67,7 @@ object SdkInsightAttachmentOperator : InsightAttachmentOperator {
             val attachmentId = attachmentUrlResolver.parseAttachmentIdFromPathInformation(url)
             val attachmentBean = objectFacade.loadAttachmentBeanById(attachmentId)
             fileManager.getObjectAttachmentContent(attachmentBean.objectId, attachmentBean.nameInFileSystem)
-        }
-
-    suspend fun downloadAttachmentById(attachmentId: AttachmentId): Either<InsightClientError, InputStream> =
-        catchAsInsightClientError {
-            val attachmentBean = objectFacade.loadAttachmentBeanById(attachmentId.raw)
-            fileManager.getObjectAttachmentContent(attachmentBean.objectId, attachmentBean.nameInFileSystem)
-        }
+        }.mapLeft { OtherNotFoundError("Attachment download failed for url:$url") }
 
     override suspend fun downloadAttachmentZip(objectId: InsightObjectId): Either<InsightClientError, InputStream> =
         either {

kotlin-insight-client/kotlin-insight-client-sdk/src/main/kotlin/com/linkedplanet/kotlininsightclient/sdk/services/ReverseEngineeredAttachmentUrlResolver.kt

@@ -34,7 +34,7 @@ internal class ReverseEngineeredAttachmentUrlResolver {
 
     private val applicationProperties: ApplicationProperties by getComponent()
 
-    private val pattern = Pattern.compile(".*/(\\d+)/?")
+    private val pattern = Pattern.compile(".*/(\\d+)(/[^/]*)?$")
     private val INSIGHT_REST_BASE_URL = "/rest/insight/1.0"
 
     private fun baseUrl(): String = applicationProperties.jiraBaseUrl