Skip to content

Commit c4f3c4b

Browse files
committed
contest: collector: don't discard results with crashes due to instability
Some tests always fail but they may start to trigger crashes. In that case we want to make sure the crashes / warnings are noticed. Never filter out results with crashes based on stability. Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 0c7c03f commit c4f3c4b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

contest/results-collector.py

+6
Original file line numberDiff line numberDiff line change
@@ -300,12 +300,18 @@ def filter_l1(test):
300300
# Defer filtering to L2
301301
if test.get("results"):
302302
return True
303+
# Crashes must always be reported
304+
if test.get("crashes"):
305+
return True
303306
return (test['group'], test['test'], None) not in unstable[u_key]
304307

305308
def trim_l2(test):
306309
# Skip over pure L1s
307310
if "results" not in test:
308311
return test
312+
# Crashes must always be reported
313+
if test.get("crashes"):
314+
return test
309315

310316
def filter_l1_l2(case):
311317
return (test['group'], test['test'], case['test']) not in unstable[u_key]

0 commit comments

Comments
 (0)