New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing error in ApiException #18

Open

seedspirit opened this issue Sep 29, 2024 · 0 comments

Assignees

Labels

Contributor

seedspirit commented Sep 29, 2024

Error exists in parsing unsuccessful response to ApiErrorResponse in ApiException class.
It seems it occurred because wrong method called

// wrong method
return new Gson().fromJson(response.body().toString(), ApiErrorResponse.class);

// corrected method
return new Gson().fromJson(response.body().string(), ApiErrorResponse.class);

Can I fix it and make a pull request?

namkyu1999 assigned seedspirit

namkyu1999 added the mentorship-kr label

namkyu1999 added this to Open Source Contribution Academy 2024

namkyu1999 moved this to In Progress in Open Source Contribution Academy 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment