Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticipantAttributesChanged behavior before 2.5.5 #1290

Open
valeredev opened this issue Oct 15, 2024 · 0 comments
Open

ParticipantAttributesChanged behavior before 2.5.5 #1290

valeredev opened this issue Oct 15, 2024 · 0 comments

Comments

@valeredev
Copy link

Describe the problem

Hello,

Up to version 2.5.4, the ParticipantAttributesChanged event included the old values of the attributes that had changed.
Since version 2.5.5, it only passes down the current value. This change doesn't provide any extra information, as the new value is already available on the Participant object.

This change affects how we can track attribute modifications. With the old method, it was easier to see what had changed. The new approach requires more work on the client side to keep track of changes, without offering any additional benefits.

Describe the proposed solution

ParticipantAttributesChanged should send either the old value alone, or both the old and new values.

The previous method allowed us to see changes between values, while also getting the updated value from the Participant object.

Now, we can't see these changes unless we keep a copy of the state on the client side.

Alternatives considered

  • Revert to previous behavior:
    This approach offers more flexibility. It allows us to return to a system that may have been more adaptable or had fewer constraints.

  • Include the old value in the parameters of ParticipantAttributesChanged:
    This solution provides better convenience and compatibility. While it introduces a slight redundancy (as the new value is already synchronized on the client side)

Importance

would make my life easier

Additional Information

I actually implemented a lot of logic in my client app based on the ability to easily track deltas between attributes. I didn't think it was a bug because while at first I was expecting the new value in changedAttributes, I found it was more convenient to have the delta available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant