Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing screen seems to be a bit washed out #53

Open
peca123 opened this issue Dec 4, 2023 · 2 comments
Open

Sharing screen seems to be a bit washed out #53

peca123 opened this issue Dec 4, 2023 · 2 comments

Comments

@peca123
Copy link

peca123 commented Dec 4, 2023

Describe the bug
Hey there!

When sharing screen in Unity, it appears a bit washed out, is it supposed to be like this, or could this be changed/ configured?
This is not the case for camera sharing, camera sharing's colors are true and vivid.

Thanks in advance! :)

Client

  • SDK: LiveKit WebGL SDK for Unity
  • Version: [1.5.0]

To Reproduce
Steps to reproduce the behavior:

  1. A client is connected to the room
  2. A clients starts sharing screen by creating a streaming track
  3. Shared screen is a bit washed out (paler than expected)

Expected behavior
Screen share's colors should be true just like share webcam's

Screenshots
livekit-washout

@277861535
Copy link

I also encountered the same problem. Have you solved it

@peca123
Copy link
Author

peca123 commented Jun 12, 2024

Hey there! Yes, after a lot of research, I determined the reason behind this is because I was using Linear color space instead of gamma, for which livekit unity sdk is made. Colors can be converted between gamma and linear color spaces, so a solution for me was making a very simple shader for live kit, and use it for every material on objects I want live kit on. The only thing shader does is color power 2.2 (that's the formula for converting gamma > linear) when streaming is happening (if you need it reverted to static regular image, revert the pow to 1). This has proven to work like a charm, if you need any more insight into this, feel free to ask :)

@davidzhao davidzhao transferred this issue from livekit/livekit Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants