Making export

[parteekcoder]

issue #366

@NikhilM98 @llaske
On clicking the export button which I added , based on filters it will download the result

[NikhilM98]

Don't you already have a PR open addressing this issue?

[parteekcoder]

Don't you already have a PR open addressing this issue?

yeah in that PR you removed my confusion regarding the feature actually required , that's why I shifted to new

[parteekcoder]

Hey @llaske @NikhilM98 please review this PR

What I have done here is:-
when you click on export assignment button it will download the CSV files based on filters

I would to like hear your suggestions and work upon them

[NikhilM98]

@parteekcoder there are some linting issues with this PR. Can you handle them?

[parteekcoder]

@parteekcoder there are some linting issues with this PR. Can you handle them?

sure I will remove that , but there is also an other PR having the same code 396

[parteekcoder]

@parteekcoder there are some linting issues with this PR. Can you handle them?

yeah @NikhilM98 , now I removed all the lint errors thanks for reminding

Now you can review

[parteekcoder]

hey @NikhilM98 I removed all eslint error in my code

[NikhilM98]

sure I will remove that , but there is also an other PR having the same code 396

It's okay to have another PR for the same issue if it's intended for GSoC. The quality of PRs is an important factor for evaluating the understanding of a contributor about the project.

[parteekcoder]

sure I will remove that , but there is also an other PR having the same code 396

It's okay to have another PR for the same issue if it's intended for GSoC. The quality of PRs is an important factor for evaluating the understanding of a contributor about the project.

@NikhilM98 If you would like anything needs to be improved in the PR , I will appreciate that and will update it

[parteekcoder]

@NikhilM98 done the changes you suggested , I can also update the fields which you would like to keep in .csv file

Thanks for your review

[parteekcoder]

hey @llaske @NikhilM98 @ricknjacky please can you review this pull request so that it can be merged. And we can the discuss the fields to be exported in the csv file

[llaske]

Hi @parteekcoder ,
Thanks for this contribution.
Some information are missing: student name, delivery date and score.

[parteekcoder]

Yeah sure @llaske i will add those , thanks for testing and your invaluable time.

If you have any suggestions I will be happy to work on them

[parteekcoder]

Hi @llaske @NikhilM98 @ricknjacky ,
Thanks @llaske for testing this PR, I included the fields you told. And updated the PR

Please let me know if there are other changes to be made to improve this PR

[llaske]

It's nice. Please fix my comment.

[llaske]

Please remove debug message.

[parteekcoder]

Oh!! yes , i forget to remove it. I will update the pr

[llaske]

Thanks @parteekcoder , good job.

[parteekcoder]

@llaske thanks for testing efforts and the suggestions you give to improve code quality