[clang-repl] Skip tests for non-linux and non-darwin platforms from #152562

[kr-2003]

No description provided.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Abhinav Kumar (kr-2003)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/153005.diff

1 Files Affected:

• (modified) clang/unittests/Interpreter/OutOfProcessInterpreterTests.cpp (+8)

diff --git a/clang/unittests/Interpreter/OutOfProcessInterpreterTests.cpp b/clang/unittests/Interpreter/OutOfProcessInterpreterTests.cpp
index 4d5ef5c70d135..1e261e786c2e8 100644
--- a/clang/unittests/Interpreter/OutOfProcessInterpreterTests.cpp
+++ b/clang/unittests/Interpreter/OutOfProcessInterpreterTests.cpp
@@ -134,6 +134,14 @@ TEST_F(InterpreterTestBase, SanityWithRemoteExecution) {
   if (!HostSupportsJIT())
     GTEST_SKIP();
 
+  llvm::Triple SystemTriple(llvm::sys::getProcessTriple());
+
+  // FIXME: In the future, support more platforms beyond linux-x86_64 and macOS.
+  if (!SystemTriple.isOSDarwin() && !SystemTriple.isOSLinux()) {
+    GTEST_SKIP()
+        << "Out-of-process interpreter only supports linux-x86_64 and macos";
+  }
+
   std::unique_ptr<Interpreter> Interp = createInterpreterWithRemoteExecution();
 
   using PTU = PartialTranslationUnit;

[kr-2003]

@rorth Can you review this?

[rorth]

(Some commenting the code directly didn't work for me ;-)

This check

!SystemTriple.isOSLinux()

isn't enough: it encompasses any version of Linux, not just Linux/x86_64. Besides, as I said, getOrcRuntimePath currently hardcodes the runtimes layout while one can still use the projects layout if one so chooses. I'd rather you'd skip the test unconditionally until this is all figured out: as is, the cost is way too fragile and makes many unwarranted assumptions.

[kr-2003]

I understand your concern about the fragility of the check and the hardcoded assumptions in getOrcRuntimePath.
In this case, though, the feature under test is explicitly implemented only for linux-x86_64 and macOS/Darwin. Because of this, I think it’s important to still run the test on these supported platforms.