Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-outlier parameter should consistently be definable as regression #646

Open
AlexanderFengler opened this issue Jan 31, 2025 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@AlexanderFengler
Copy link
Collaborator

We are currently treating p-outlier in a special way, and it implies that this parameter can be estimated, but only globally not via a regression. I don't think there is anything that absolutely forces us to do that, it is rather a legacy decision that wasn't revisited since a long time.

Instead, we should allow p-outlier to be included in the config dict, and if included, it should be treated like any other parameter.

In addition to a bit of extra logic on identifying the presence of p-outlier in the include argument, this will likely need a bit of surgery on our likelihood constructors to respect entry of p-outlier as a vector parameter.

@AlexanderFengler AlexanderFengler added the enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant