Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yamllint and ansible-lint to travis for all roles #45

Open
lerwys opened this issue Dec 12, 2019 · 2 comments
Open

Add yamllint and ansible-lint to travis for all roles #45

lerwys opened this issue Dec 12, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lerwys
Copy link
Contributor

lerwys commented Dec 12, 2019

Problem: There are many issues with linter, both yaml and ansible. We should add a target to travis to run these linters for all roles.

@lerwys lerwys added the enhancement New feature or request label Dec 12, 2019
@lerwys lerwys self-assigned this Dec 12, 2019
@carneirofc
Copy link
Contributor

One thing that is not directly related to this but will certainly mitigate problems with bad code being uploaded is the usage of pre-commit. More specifically if we enable ansible-lint within it, as describe here https://ansible-lint.readthedocs.io/en/latest/configuring.html#pre-commit-setup.
I have been using pre-commit on most of my projects and it has been really helpful.
Every contributor must use pre-commit though (which is not difficult at all).

@carneirofc
Copy link
Contributor

PR #295 will address this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants