Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default clusterRole ineffecient for vcluster serviceaccount #42

Open
jbarfield opened this issue Dec 27, 2023 · 4 comments
Open

default clusterRole ineffecient for vcluster serviceaccount #42

jbarfield opened this issue Dec 27, 2023 · 4 comments

Comments

@jbarfield
Copy link
Contributor

jbarfield commented Dec 27, 2023 •
edited by ThomasK33
Loading

I had to update the clusterrole RBAC permissions in order for this plugin to work.

k3s version 1.6.29 on k8s 1.26.5 (kubespray).

Yaml like so:

- apiGroups:
  - cert-manager.io
  resources:
  - certificates
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - cert-manager.io
  resources:
  - issuers
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - ""
  resources:
  - secrets
  verbs:
  - get
  - list
  - watch
@FabianKramm
Copy link
Member

@jbarfield thanks for creating this issue! Would you mind to create a small PR for this?

@jbarfield
Copy link
Contributor Author

Sure thing. I just received this notification or I would have done it then.

jbarfield added a commit to jbarfield/vcluster-plugins that referenced this issue Jan 16, 2024
@jbarfield
Update cert-manager/plugin.yaml; applying RBAC rules addressing
960eaa8 
github issue loft-sh#42 opened by myself.

Applied `yamllint` updates to address syntax errors. Including
converting the array from `["bracketed format"]` to `- itemized per line` `
to eliminate `line length exceeds 80 characters` errors.
@jbarfield jbarfield mentioned this issue Jan 16, 2024
Merged
@jbarfield
Copy link
Contributor Author

PR #43 opened to address this issue.

@jbarfield
Copy link
Contributor Author

Just wanted to bump this issue in case the previous notification regarding PR43 did not get seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbarfield @FabianKramm